code-review-cpp
Security review of C / C++ code — memory-safety and the classic unsafe-API sinks. Load when reviewing C/C++ source/PR, on .c/.cc/.cpp/.h in scope, or "review this C code". Signals: Makefile/CMakeLists, strcpy/sprintf/memcpy, malloc/free, raw pointers, format strings, parsers.
v2026.10.14-ee0e0c53 instalaciones+3 en 7 días27 EstrellasMITsincronizado hace 23 horas
Instalar
¿Aún no tienes la CLI de NotHoly? Instálala primero.
$ curl -fsSL https://notholy.com/install.sh | sh$ notholy skills install noorqureshi/code-review-cppEscribe en ~/.notholy/skills después de comprobar la firma y el SHA-256.
FirmaFirmado, ed25519
Paquete0fe75f4c…55fb5ea5
0fe75f4cd96f…d74355fb5ea51 archivo · 1.7 KBEscaneoBajosin hallazgos
Fuentegithub.com/NoorQureshi/security-skills/tree/main/skills/code-review/code-review-cpp@ee0e0c5
Esta entrada todavía no está escrita en tu idioma, así que aparece en English.
En esta página
When it applies
Reviewing native C/C++ (a service, a parser, a library). The bugs are overwhelmingly memory safety — the highest-impact, most exploitable class — plus the handful of unsafe APIs that cause them.
Why it works
C/C++ has no bounds checking: a length mistake, a lifetime mistake, or attacker-controlled format string becomes a memory-corruption primitive. Most of these trace to a small, greppable set of APIs and patterns, and sanitizers/fuzzing confirm the ones static reading only suspects.
Sinks & patterns (grep, then reason about lengths and lifetimes)
- Buffer overflow:
strcpy,strcat,sprintf,gets,scanf("%s"),memcpy/memmovewith an unchecked or attacker-influenced length; fixed stack buffers filled from input. - Format string:
printf(user),fprintf(f, user),syslog(user)— user data as the format arg. - Integer issues: size/length arithmetic that can overflow or go negative and then feeds an
allocation or copy (
malloc(n*size),len-1); signed/unsigned confusion in bounds checks. - Use-after-free / double-free:
freethen use; ownership unclear across functions; dangling pointers after realloc; C++ iterator invalidation, dangling references,std::movemisuse. - Off-by-one / OOB:
<=in loop bounds, missing NUL terminator,strncpynot null-terminating. - Command/path:
system/popen/exec*with concatenated input; unchecked../in path handling. - C++ specifics: unchecked
.at()vs[], unsafereinterpret_cast, deserialization of untrusted data into objects,std::string↔C-string length mistakes.
Method
- Run
clang --analyze/cppcheckandsemgrep; treat as leads. rg 'strcpy|strcat|sprintf|gets|memcpy|system\(|printf\s*\([^"]'and, for each, trace the size and the source of the data.- For every allocation/copy, check the length's origin and arithmetic for overflow.
- Where reachable with input, confirm with a fuzzer + ASan (
libFuzzer/AFL++) — a crash under ASan is proof; escalate toexploit-memory-corruptionfor exploitability.
Gotchas
- A crash isn't automatically exploitable, but under ASan it's a real memory-safety bug worth reporting.
- Modern C++ (
std::span,std::string_view, smart pointers) reduces but doesn't remove these — raw buffers and FFI boundaries are where they persist. strncpy/snprintfare safer but have their own truncation/termination traps — read the lengths.
References
CERT C/C++ Coding Standard; OWASP C-Based Toolchain hardening; ASan/libFuzzer docs.
Archivos de esta versión
- SKILL.md3.1 KB
Permisos
| Permiso | Declarado | Hallado en el escaneo |
|---|---|---|
| Lee archivos | No | No |
| Escribe archivos | No | No |
| Ejecuta comandos de shell | No | No |
| Usa la red | No | No |
| Usa conectores | No | No |
| Controla un navegador | No | No |
Hallazgos del escaneo
Revisado el 13 nov 2026
El escaneo no encontró nada que señalar en esta versión.
Un escaneo limpio baja el riesgo, pero no prueba que el paquete sea seguro. Lee lo que instalas.
| Versión | Publicada | Commit | SHA-256 | Firma | Cambio de permisos |
|---|---|---|---|---|---|
| v2026.10.14-ee0e0c5 | 13 nov 2026 | ee0e0c5 | 0fe75f4c | Firmada | – |
Más de NoorQureshi
Todo de este publicadorMás en Web y bug bounty
Ver la categoría- src-hunterzhaoxuya520/src-hunter5
- owasp-top10-analysissecurityskills/owasp-top10-analysis5
- testing-for-xml-injection-vulnerabilitiesmukul975/testing-for-xml-injection-vulnerabilities5
- offensive-xsssnailsploit/offensive-xss5
- offensive-rcesnailsploit/offensive-rce5
- source-review-techniqueaeondave/source-review-technique5
Pregunta todo lo que tu alcance permite.
Crea la cuenta, añade créditos y haz la primera pregunta en el chat o en la terminal.
- 1/3
Crea la cuenta
Individual o empresa. Puedes pasar a empresa después sin perder saldo ni claves.
IndividualEmpresa - 2/3
Añade créditos
Con tarjeta. Pagas por token, sin suscripción.
$5.00recarga mínima - 3/3
Pregunta
En el chat, o instala el CLI y ejecuta notholy login en tu terminal.
$ notholy login