code-review-cpp
Security review of C / C++ code — memory-safety and the classic unsafe-API sinks. Load when reviewing C/C++ source/PR, on .c/.cc/.cpp/.h in scope, or "review this C code". Signals: Makefile/CMakeLists, strcpy/sprintf/memcpy, malloc/free, raw pointers, format strings, parsers.
v2026.10.14-ee0e0c53 installs+3 in 7 days27 StarsMITsynced 23 hours ago
Install
No NotHoly CLI yet? Install it first.
$ curl -fsSL https://notholy.com/install.sh | sh$ notholy skills install noorqureshi/code-review-cppWrites to ~/.notholy/skills after checking the signature and the SHA-256.
SignatureSigned, ed25519
Package0fe75f4c…55fb5ea5
0fe75f4cd96f…d74355fb5ea51 file · 1.7 KBScanLowno findings
Sourcegithub.com/NoorQureshi/security-skills/tree/main/skills/code-review/code-review-cpp@ee0e0c5
On this page
When it applies
Reviewing native C/C++ (a service, a parser, a library). The bugs are overwhelmingly memory safety — the highest-impact, most exploitable class — plus the handful of unsafe APIs that cause them.
Why it works
C/C++ has no bounds checking: a length mistake, a lifetime mistake, or attacker-controlled format string becomes a memory-corruption primitive. Most of these trace to a small, greppable set of APIs and patterns, and sanitizers/fuzzing confirm the ones static reading only suspects.
Sinks & patterns (grep, then reason about lengths and lifetimes)
- Buffer overflow:
strcpy,strcat,sprintf,gets,scanf("%s"),memcpy/memmovewith an unchecked or attacker-influenced length; fixed stack buffers filled from input. - Format string:
printf(user),fprintf(f, user),syslog(user)— user data as the format arg. - Integer issues: size/length arithmetic that can overflow or go negative and then feeds an
allocation or copy (
malloc(n*size),len-1); signed/unsigned confusion in bounds checks. - Use-after-free / double-free:
freethen use; ownership unclear across functions; dangling pointers after realloc; C++ iterator invalidation, dangling references,std::movemisuse. - Off-by-one / OOB:
<=in loop bounds, missing NUL terminator,strncpynot null-terminating. - Command/path:
system/popen/exec*with concatenated input; unchecked../in path handling. - C++ specifics: unchecked
.at()vs[], unsafereinterpret_cast, deserialization of untrusted data into objects,std::string↔C-string length mistakes.
Method
- Run
clang --analyze/cppcheckandsemgrep; treat as leads. rg 'strcpy|strcat|sprintf|gets|memcpy|system\(|printf\s*\([^"]'and, for each, trace the size and the source of the data.- For every allocation/copy, check the length's origin and arithmetic for overflow.
- Where reachable with input, confirm with a fuzzer + ASan (
libFuzzer/AFL++) — a crash under ASan is proof; escalate toexploit-memory-corruptionfor exploitability.
Gotchas
- A crash isn't automatically exploitable, but under ASan it's a real memory-safety bug worth reporting.
- Modern C++ (
std::span,std::string_view, smart pointers) reduces but doesn't remove these — raw buffers and FFI boundaries are where they persist. strncpy/snprintfare safer but have their own truncation/termination traps — read the lengths.
References
CERT C/C++ Coding Standard; OWASP C-Based Toolchain hardening; ASan/libFuzzer docs.
Files in this version
- SKILL.md3.1 KB
Permissions
| Permission | Declared | Found by the scan |
|---|---|---|
| Reads files | No | No |
| Writes files | No | No |
| Runs shell commands | No | No |
| Uses the network | No | No |
| Uses connectors | No | No |
| Drives a browser | No | No |
Scan findings
Reviewed on Nov 13, 2026
The scan found nothing to flag in this version.
A clean scan lowers the risk but does not prove a package is safe. Read what you install.
| Version | Published | Commit | SHA-256 | Signature | Permission change |
|---|---|---|---|---|---|
| v2026.10.14-ee0e0c5 | Nov 13, 2026 | ee0e0c5 | 0fe75f4c | Signed | – |
More from NoorQureshi
All from this publisherMore in Web and bug bounty
See the category- src-hunterzhaoxuya520/src-hunter5
- owasp-top10-analysissecurityskills/owasp-top10-analysis5
- testing-for-xml-injection-vulnerabilitiesmukul975/testing-for-xml-injection-vulnerabilities5
- offensive-xsssnailsploit/offensive-xss5
- offensive-rcesnailsploit/offensive-rce5
- source-review-techniqueaeondave/source-review-technique5
Ask anything your scope allows.
Create an account, add credits and ask the first question in the chat or the terminal.
- 1/3
Create the account
Individual or company. You can switch to a company later without losing balance or keys.
IndividualCompany - 2/3
Add credits
By card. Pay per token, no subscription.
$5.00minimum deposit - 3/3
Ask
In the chat, or install the CLI and run notholy login in your terminal.
$ notholy login