code-review-rust
Security review of Rust code — where a memory-safe language still has real bugs: `unsafe`, FFI, panics, and the usual injection/logic sinks. Load when reviewing Rust source/PR, on .rs / Cargo.toml in scope, or "review this Rust". Signals: Cargo.toml, unsafe blocks, extern "C", unwrap/expect, actix/a
v2026.10.14-ee0e0c53 installs+3 in 7 days27 StarsMITsynced 23 hours ago
Install
No NotHoly CLI yet? Install it first.
$ curl -fsSL https://notholy.com/install.sh | sh$ notholy skills install noorqureshi/code-review-rustWrites to ~/.notholy/skills after checking the signature and the SHA-256.
SignatureSigned, ed25519
Packaged6db3498…84e8534a
d6db34984f71…fbc584e8534a1 file · 1.8 KBScanMedium1 finding
- injection.no_confirmationSKILL.md:55
Sourcegithub.com/NoorQureshi/security-skills/tree/main/skills/code-review/code-review-rust@ee0e0c5
On this page
When it applies
Reviewing Rust (a service, a CLI, a library). Safe Rust removes most memory bugs, so the review focuses on the places safety is opted out of, the ways Rust code still panics or mis-handles input, and ordinary injection/logic in web handlers.
Why it works
Rust's guarantees hold only outside unsafe and only for memory safety — they don't stop SQL built
by string, a command run via a shell, a .unwrap() that panics on attacker input (DoS), or a logic
error. Concentrating on those boundaries finds the real bugs efficiently.
Sinks & patterns (grep, then reason about the boundary)
unsafeblocks: every one is a manual proof obligation — raw pointer deref,get_unchecked,slice::from_raw_parts,mem::transmute, uninitialised memory. Check the invariant it assumes.- FFI:
extern "C"/bindgenboundaries — lengths, lifetimes, and NUL handling across the C edge (the C side has none of Rust's guarantees; pair withcode-review-cpp). - Panics as DoS:
unwrap/expect/panic!/indexingv[i]/unreachable!on attacker-controlled input; integerascasts that truncate; arithmetic overflow (panics in debug, wraps in release — both can be bugs). Prefer?/checked ops. - Injection: SQL via
format!into a query instead of parameter binding (sqlx/diesel);std::process::Commandwithsh -cand concatenated input;Commandarg vs shell form. - Path / SSRF: user paths joined without canonicalisation + prefix check; HTTP clients (reqwest) fetching user URLs.
- Deserialization / web:
serdeinto types from untrusted data (resource exhaustion, unexpected variants); actix/axum/rocket extractors bound to over-broad structs (mass assignment); missing auth middleware on state-changing routes.
Method
- Run
cargo audit(known-vuln deps),cargo clippy, andsemgrep;miriforunsafeUB where feasible. rg 'unsafe|unwrap\(\)|expect\(|transmute|Command::new|format!\(.*(SELECT|INSERT|UPDATE)'→ review each.- Justify every
unsafeblock's invariant; if you can't, that's a finding. - Confirm exploitable injection/logic with the matching runtime skill.
Gotchas
- Idiomatic Rust is genuinely safe — don't invent memory bugs in safe code; spend effort on
unsafe, FFI, panics, deps, and logic. - Release-mode integer overflow wraps silently — a
checked_*/saturating_*audit matters for size/index math. cargo auditflags vulnerable crates you'd never see by reading — always run it.
References
Rustonomicon (unsafe); RustSec advisory DB / cargo-audit; Clippy lint set; Secure Rust Guidelines (ANSSI).
Files in this version
- SKILL.md3.2 KB
Permissions
| Permission | Declared | Found by the scan |
|---|---|---|
| Reads files | No | No |
| Writes files | No | No |
| Runs shell commands | No | No |
| Uses the network | No | No |
| Uses connectors | No | No |
| Drives a browser | No | No |
Scan findings
Reviewed on Nov 13, 2026
- MediumPrompt injection · injection.no_confirmationSKILL.md:55
A clean scan lowers the risk but does not prove a package is safe. Read what you install.
| Version | Published | Commit | SHA-256 | Signature | Permission change |
|---|---|---|---|---|---|
| v2026.10.14-ee0e0c5 | Nov 13, 2026 | ee0e0c5 | d6db3498 | Signed | – |
More from NoorQureshi
All from this publisherMore in Web and bug bounty
See the category- src-hunterzhaoxuya520/src-hunter5
- owasp-top10-analysissecurityskills/owasp-top10-analysis5
- testing-for-xml-injection-vulnerabilitiesmukul975/testing-for-xml-injection-vulnerabilities5
- offensive-xsssnailsploit/offensive-xss5
- offensive-rcesnailsploit/offensive-rce5
- source-review-techniqueaeondave/source-review-technique5
Ask anything your scope allows.
Create an account, add credits and ask the first question in the chat or the terminal.
- 1/3
Create the account
Individual or company. You can switch to a company later without losing balance or keys.
IndividualCompany - 2/3
Add credits
By card. Pay per token, no subscription.
$5.00minimum deposit - 3/3
Ask
In the chat, or install the CLI and run notholy login in your terminal.
$ notholy login